Skip to content

Add rank filter#37340

Open
Valerus9 wants to merge 6 commits intoppy:masterfrom
Valerus9:toprankfilter
Open

Add rank filter#37340
Valerus9 wants to merge 6 commits intoppy:masterfrom
Valerus9:toprankfilter

Conversation

@Valerus9
Copy link
Copy Markdown
Contributor

@Valerus9 Valerus9 commented Apr 18, 2026

Adds a rank filter which accepts grades/ranks (F, D, C, B, A, S, SH, X, XH) and None as input.

showcase:

2026-04-20.09-08-03.mp4

Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
Comment thread osu.Game/Screens/Select/BeatmapCarouselFilterMatching.cs Fixed
Comment thread osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs Fixed
@Valerus9
Copy link
Copy Markdown
Contributor Author

I don't know how to fix this:
Failed TestExitFromFailedGameplayAfterFailAnimation [10 s]

@diquoks
Copy link
Copy Markdown
Contributor

diquoks commented Apr 19, 2026

I don't know how to fix this: Failed TestExitFromFailedGameplayAfterFailAnimation [10 s]

most likely, this is a flaky test

in such PRs if at least one of the four tests on the machines is completed, then everything is fine

@peppy
Copy link
Copy Markdown
Member

peppy commented Apr 20, 2026

Where does "toprank" come from? It's such a weird term. Just rank= would be fine I think, unless there's some history i'm unaware of.

@Valerus9 Valerus9 changed the title Add toprank filter Add rank filter Apr 20, 2026
@Valerus9
Copy link
Copy Markdown
Contributor Author

Where does "toprank" come from? It's such a weird term. Just rank= would be fine I think, unless there's some history i'm unaware of.

No there is no history. Changed it to rank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants