Pass list of active mods when calculating score multiplier#37355
Open
tsunyoku wants to merge 1 commit intoppy:masterfrom
Open
Pass list of active mods when calculating score multiplier#37355tsunyoku wants to merge 1 commit intoppy:masterfrom
tsunyoku wants to merge 1 commit intoppy:masterfrom
Conversation
Required to support some changes in the ongoing mod multipliers work. With the existing set of multipliers there are no changes expected here, but have changed some mods locally and tested this works as expected. To support this server-side, a game bump alongside any multiplier changes should be enough. Score reverification is the only place this matters, and it falls back onto `StandardisedScoreMigrationTools` so no code changes necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to support some changes in the ongoing mod multipliers work.
With the existing set of multipliers there are no changes expected here, but have changed some mods locally and tested this works as expected.
To support this server-side, a game bump alongside any multiplier changes should be enough. Score reverification is the only place this matters, and it falls back onto
StandardisedScoreMigrationToolsso no code changes necessary.