Refactor 09042025 #524
Open
Refactor 09042025 #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added hex color validation to useBackground hook. - Introduced options for enabling/disabling and customizing key events in useEscapeKey and useOutsideClick hooks. - Implemented cleanup functionality in useMediaState hook. - Enhanced useWindowSize hook with debouncing for resize events. - Updated useCardSize hook to improve text content size calculation. - Refactored useUIState to support boolean state toggling.
- Added new Rollup plugins: @rollup/plugin-alias, @rollup/plugin-dynamic-import-vars, @rollup/plugin-replace, and rollup-plugin-progress. - Updated package.json and pnpm-lock.yaml to include new dependencies. - Enhanced rollup.config.mjs with sourcemaps and improved production optimizations. - Refined README.md for clarity and consistency in instructions.
- Upgraded styled-components and various dependencies in package.json and pnpm-lock.yaml. - Refactored rollup configuration to improve build optimizations and added support for dynamic imports. - Removed deprecated demo data files and adjusted import paths for data modules. - Enhanced timeline components with lazy loading for better performance. - Updated snapshots to reflect changes in component structure and styles.
….yaml - Upgraded cypress dependency to version 14.3.0 for improved testing capabilities. - Updated lock file to reflect the new version and its integrity hash.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Commented out the canShowTextMemo variable in timeline-card-media.tsx to clean up the code. - Updated test imports in timeline-card-media.test.tsx to remove unused render import.
- Updated CardMedia component to use separate functions for calculating card height with and without text overlay. - Enhanced accessibility by replacing role attributes with aria-labels for arrow icons. - Refactored alt text handling in ImageDisplay and VideoPlayer components to use nullish coalescing for better default values. - Cleaned up title prop handling in MediaDetails component to ensure consistent fallback values.
- Enhanced CardMedia component by adding a data-testid for the arrow icon to improve testability. - Updated snapshot tests for timeline-horizontal-card and timeline-card-media to reflect changes in class names and structure. - Removed the frameborder attribute from the video element in the timeline-card-media snapshot for cleaner markup. - Improved regex in mediaUtils to correctly extract YouTube video IDs from various URL formats.
- Deleted the downloads.html file as it is no longer needed. - Removed the root path route from VerticalTimelineRoutes to streamline navigation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to various dependencies, improvements to the build configuration, and minor documentation enhancements. The most important changes include updating GitHub Actions workflows, refining the
rollup.config.mjsfile, updating dependencies inpackage.json, and improving the README documentation.Dependency Updates:
pnpm/action-setupto v4 andactions/checkoutto v4 in multiple GitHub Actions workflows, includingbuild.yml,coveralls.yml,cypress.yml, andsnyk.yamlto ensure compatibility with the latest versions. [1] [2] [3] [4]Build Configuration:
rollup.config.mjsby adding new plugins (alias,dynamicImportVars,replace,progress), enabling source maps, and optimizing the build for production environments. [1] [2] [3] [4] [5] [6]Package Updates:
package.json, includingstyled-components,eslint,cypress,typescript, androllupto their latest versions for improved stability and new features. [1] [2] [3] [4]Documentation Improvements:
Code Enhancements:
ScrollBarstyled component to include athemeprop type for better type safety.ResizeObserverin the test setup to prevent test failures related to resize events.details-text-memo.tsxto use a custom hook for background color calculation and simplified the height measurement logic. [1] [2]Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).