Skip to content

use feedkeys(xxx, 'ni'), fix #1345#1493

Merged
prabirshrestha merged 1 commit into
prabirshrestha:masterfrom
ZSaberLv0:master
Oct 16, 2023
Merged

use feedkeys(xxx, 'ni'), fix #1345#1493
prabirshrestha merged 1 commit into
prabirshrestha:masterfrom
ZSaberLv0:master

Conversation

@ZSaberLv0

Copy link
Copy Markdown
Contributor

No description provided.

@prabirshrestha

Copy link
Copy Markdown
Owner

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

@ZSaberLv0

Copy link
Copy Markdown
Contributor Author

@ZSaberLv0 can you rebase to latest master and fix the merge conflicts?

@prabirshrestha merged

@prabirshrestha

Copy link
Copy Markdown
Owner

Have you also tried #1429. Seems a bit similar

@ZSaberLv0

ZSaberLv0 commented Oct 13, 2023

Copy link
Copy Markdown
Contributor Author

Have you also tried #1429. Seems a bit similar

it also solves the issue, by a different logic:

  • use feedkeys(xxx, 'ni') : insert keys instead of append, process s:on_complete_done_after before other plugins
    • this may also cause issue if other plugins also used feedkeys(xxx, 'ni') and called before vim-lsp
  • use Allow running complete_done_after() in normal mode #1429 : wait until other plugin's done, and conditionally call s:on_complete_done_after by checking mode() state changes
    • this may (or may not) cause s:on_complete_done_after won't be called

@prabirshrestha prabirshrestha merged commit 822c6ac into prabirshrestha:master Oct 16, 2023
@prabirshrestha

Copy link
Copy Markdown
Owner

Merged. Thanks!

@prabirshrestha

Copy link
Copy Markdown
Owner

Had to revert the PR. didn't work with https://github.com/cohama/lexima.vim.

ompugao pushed a commit to ompugao/vim-lsp that referenced this pull request Dec 9, 2023
ompugao pushed a commit to ompugao/vim-lsp that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants