_api.sass: use positive selector #891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The negative selectors are very slow, causing the API page to very sluggish on load and on window resize. According to Chrome's devtools, all CSS selectors together on my API page took 35ms with 2'372'367 match attempts. With this change it's 5ms with 309'321 match attempts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The negative selectors are very slow, causing API docs to be slower to render.
According to Chrome's devtools, all CSS selectors together on my API page took 2'372'367 match attempts. With this change it's 309'321 match attempts.
Together with #892 I'm getting 368 ms of time to render the page instead of 428 ms from a best of three experiment. I kinda expect static docs to load instantly, which means sub 300ms, but this is OK I guess.