-
Notifications
You must be signed in to change notification settings - Fork 369
icons.html: reduce size by 54% #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c19eb91 to
131bb0e
Compare
Should perhaps be avoided: |
Self-closing tags are already used, e.g.
See this comment by the person who created https://svgomg.net/, or more authoritatively the html spec which says it's not an error when in |
131bb0e to
587b02e
Compare
|
Is there any way to ensure/enforce this? Without that, I'm certain that there'd be a regression around this the next time that the icons need any changes. |
|
I'm not in the loop regarding web development tooling. Just know about w3 validator (ancient) and |
|
@pradyunsg would you accept this as is or do you want to merge it exclusively with tooling? I cannot work on tooling unfortunately. |
I'll take a stab at it. Thanks for flagging this BTW! 😄 |
since these icons are part of the HTML and aren't cached, it wouldn't hurt to reduce their size a bit
<svg>nested inside<svg><use/>instead of<use></use>^icon to icons.htmlxmlns=attribute from inline<svg>elements