Fixes to v3 tests#75
Merged
Merged
Conversation
added 6 commits
August 25, 2025 10:10
…e template tests for the time being, as those aren't consistent
…e template tests for the time being, as those aren't consistent
…com:praekeltfoundation/platform-mnch into fixes-to-v3-tests
rudigiesler
approved these changes
Aug 26, 2025
| setup [:setup_flow] | ||
|
|
||
| describe "DMA Form" do | ||
| # TODO: I don't see the point of this test file, as 'dma-form_test.ex' already tests form functionality in much more depth |
Contributor
There was a problem hiding this comment.
Was this maybe the original test file from the base CMS Journeys that we had? (we usually copy them as a base and then edit them). I'm happy to delete it rather since we have the test coverage in another file.
| end | ||
|
|
||
| describe "checkpoints" do | ||
| @tag :thisone |
Contributor
There was a problem hiding this comment.
We can probably remove this tag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor updates to my previous PR.