fixed format_field_value issue#219
Merged
Merged
Conversation
erikh360
reviewed
Nov 25, 2025
erikh360
left a comment
erikh360
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, do we have tests for these?
Contributor
Author
|
@erikh360 yes the class itself has tests, I just added a part that makes sure we prevent incorrectly parsing non strings as dates and now return them unchanged. |
erikh360
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing this glitchtip issue: https://glitchtip.prd.momconnect.co.za/momconnect/issues/80.
A TypeError is raised in production because the Python function datetime.fromisoformat() is receiving None instead of a string.