adding attempt at logging middleware to vumi2 by MatthewWeppenaar · Pull Request #97 · praekeltfoundation/vumi2

MatthewWeppenaar · 2025-06-17T14:33:39Z

Purpose

We need to do some work to add a unidecoder middleware to Vumi2. Before starting on this work, we should implement a basic logging middleware

Checklist

Added or updated unit tests
Added to release notes
Updated readme/documentation (if necessary)

… on workers

…est for middleware enabled on different connections

…lass fetched to be BaseMiddleWareConfig

…ing worker test for logging middleware

jerith

Looks good. Can you look through the various TODO comments and remove the ones that no longer apply, please?

Merging in main

jerith

Looks good. All we need now are the docs, I think. 🎉

merging in main

Matthew Weppennaar and others added 22 commits June 17, 2025 16:25

adding attempt at logging middleware to vumi2

078da14

Delete src/vumi2/middlewares/tests/helpers.py

12f34b5

Delete src/vumi2/middlewares/tests/test_logging.py

8f6e3fb

Delete src/vumi2/middlewares/tests/utils.py

59a2810

Delete src/vumi2/middlewares/tests/__init__.py

8f6b2ee

adding tests from vumi1, and manipulating tests so that they pass

565a649

adding __init__ to middleware

da0f0e6

reformatting

9e4b464

attempting to fix with ruff check --fix .

8379cfb

removing conf model and creating a base config using attrs

6b53b4b

removing vumi testing stuff

8bb40b1

adding some tests for base middleware

7c6e7e6

removing zope interface

51795ab

making class_from_string a standalone module

847868f

importing test client where needed

c901ae7

adding a test to worker to handle middle wares

94fc58c

adding test for logging middleware

02137d2

reformatiing

c562ec3

fixed import orderring

f8f42c6

checking with mypy

d69d8c2

fixing for mypy

c585fa6

adding more tests to base middleware and attempting intergration test…

bdfe79d

… on workers

jerith reviewed Jun 19, 2025

View reviewed changes

Comment thread tests/test_workers.py Outdated

Comment thread tests/test_workers.py Outdated

Matthew Weppennaar added 7 commits June 19, 2025 13:15

adding inbound, outbound and event tests on connections

8da14b2

fixing event middle ware testing

79c5275

formatting

2cae1f0

adding A middleware class to reduce the risk off race conditions

8120d3a

making sure that the middleware setup is called correctly and add a t…

92943c4

…est for middleware enabled on different connections

Adding a test that checks if a log message is actually logged

658c710

removing unnecessary print statement and setting the default config c…

9924af0

…lass fetched to be BaseMiddleWareConfig

Adding tests for events on multiple middlewares

9d41f19

jerith reviewed Jun 24, 2025

View reviewed changes

Comment thread src/vumi2/middlewares/base.py Outdated

Comment thread tests/middlewares/test_base.py Outdated

Comment thread tests/middlewares/test_logging.py Outdated

Comment thread tests/test_workers.py Outdated

Comment thread tests/test_workers.py Outdated

adding unidecoder middleware and its tests

fcaac66

jerith reviewed Jun 25, 2025

View reviewed changes

Comment thread .DS_Store

Comment thread tests/middlewares/test_unicode.py

Matthew Weppennaar added 4 commits June 25, 2025 13:18

addressing comments on PR, moving middlewareworker to test/helper add…

121cc03

…ing worker test for logging middleware

renaming test and adding DS_store to gitignore

412f791

adding corrected loading of config and classes

6388dbe

formmating

dcc0771

jerith reviewed Jun 25, 2025

View reviewed changes

Matthew Weppennaar added 2 commits June 25, 2025 14:39

merging in main

e5ee4cd

removing unnecessary TODOs

82570bb

jerith reviewed Jun 25, 2025

View reviewed changes

Comment thread src/vumi2/applications/turn_channels_api/turn_channels_api.py

Comment thread tests/test_workers.py

Matthew Weppennaar added 2 commits June 26, 2025 15:32

Merge branch 'main' into middleware_implementation

441f000

Merging in main

merging in main, adding to the release notes and addressing pr comments

0367da5

jerith reviewed Jun 26, 2025

View reviewed changes

Matthew Weppennaar added 2 commits June 30, 2025 16:25

adding middleware docs

eec2830

fixing docs

f922176

jerith reviewed Jul 1, 2025

View reviewed changes

Comment thread docs/middleware.rst Outdated

Comment thread docs/middleware.rst Outdated

Matthew Weppennaar added 7 commits July 1, 2025 13:01

Merge branch 'main' into middleware_implementation

41af77b

merging in main

fixing docs

5960bec

correct indentation in code blocks

7237f0e

fixing docs

63213fc

formatting

1c3e0c8

adding different notation for methods

32fb82c

removing extra r

794d48e

jerith reviewed Jul 1, 2025

View reviewed changes

Comment thread docs/middleware/building_your_own_middleware.rst Outdated

fixing docs

8994e38

jerith approved these changes Jul 2, 2025

View reviewed changes

MatthewWeppenaar merged commit 9a7b3a7 into main Jul 2, 2025
6 checks passed

MatthewWeppenaar deleted the middleware_implementation branch July 2, 2025 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adding attempt at logging middleware to vumi2#97

adding attempt at logging middleware to vumi2#97
MatthewWeppenaar merged 55 commits into
mainfrom
middleware_implementation

MatthewWeppenaar commented Jun 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jerith left a comment

Uh oh!

Uh oh!

Uh oh!

jerith left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MatthewWeppenaar commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jerith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jerith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MatthewWeppenaar commented Jun 17, 2025 •

edited

Loading