Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Open Graph tags #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding Open Graph tags #113

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d57ddfe
Update index.html
gabrysia694 May 20, 2023
4d2f5d6
Update index.html
gabrysia694 May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,17 @@
<title>Arito - Practice Math Skills</title>
<link rel="stylesheet" href="css/basic.css">
<link rel="shortcut icon" href="assets/images/Arito_favicon.png">

<link rel="manifest" href="./manifest.json">
</head>
<link rel="stylesheet" href="css/index.css">
<!-- Open Graph Tags -->
<meta property="og:title" content="Arito">
<meta
property="og:description"
content="Practice your arithmetic skills with Arito!"
>
<meta property="og:image" content="assets\images\arito_cover.png">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think the slashes should be forward and not backward...? @gabrysia694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I copied the picture's relative path and it gave backslashes since that's what used as path separators on Windows. I'll change it, is the rest okay?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the rest lgtm @gabrysia694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

<meta property="og:type" content="website">
<meta property="og:url" content="https://arito.netlify.app">
</head>
<body>
<div class="front">
Expand Down