Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neg num of ques #131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Neg num of ques #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0139b15
bug fixed: negative number of questions handled
nishita2104 May 22, 2023
f832085
removed extra function
nishita2104 May 22, 2023
0bc764c
modified colour of error message
nishita2104 Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,17 @@ body {
background-color: var(--pink);
}

.error{
padding: 10px;
display: none;
}

.error.display-error{
display: block;
margin-bottom: 20px;
transform: translateY(-0.2);
}

/* --------------- TEST PAGE --------------- */
.test_page {
/* display: flex; */
Expand Down Expand Up @@ -279,6 +290,12 @@ body {
background-color: yellow;
}

.ques_error{
margin-top: 10px;
color: red;
background-color: rgb(255, 227, 227);
}

@media screen and (max-width: 480px) {
.question_container {
margin-bottom: 2em;
Expand Down
23 changes: 20 additions & 3 deletions js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const main_form_div = document.querySelector('.test_form');
const form_submit_btn = document.querySelector('#submit_test_form');
form_submit_btn.addEventListener('click', (e) => {
getValues();
e.preventDefault()
});

// STARTING TEST NODES REFERENCES
Expand Down Expand Up @@ -488,6 +489,18 @@ function change_max_attr_val() {
document.querySelector('#no_of_ques').setAttribute('max', maximum_questions);
}

function showError(errorElement,errorMessage) {
document.querySelector("."+errorElement).classList.add("display-error")
document.querySelector("."+errorElement).innerHTML=errorMessage
}

function clearError() {
let errors=document.querySelectorAll(".error")
for(let error of errors){
error.classList.remove("display-error")
}
}

function getValues() {
student_name = document.querySelector('#student_name').value;
q_type = document.querySelector('#questions_type').value;
Expand All @@ -499,12 +512,16 @@ function getValues() {
document.querySelector('#no_of_ques').getAttribute('max')
);
if (
student_name.length < 1 ||
isNaN(amount_of_questions) ||
amount_of_questions > max_questions
student_name.length < 1
) {
return;
}
clearError()
if(isNaN(amount_of_questions) ||
amount_of_questions > max_questions || amount_of_questions<1){
showError("ques_error","Invalid number of questions!\nPlease enter a value between 1 and 56")
return;
}

sound_player('click_sound', 'start');
createStartornotpage();
Expand Down
2 changes: 2 additions & 0 deletions pages/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ <h1>Fill them!</h1>
<div class="form_element">
<label for="no_of_ques" id="no_of_ques_label">No. of Questions (below 56)</label>
<input type="number" name="no_of_ques" id="no_of_ques" min="1" max="55" required/>
<p class="ques_error"></p>
</div>


<div class="form_element negmark_div">
<input type="checkbox" name="negmarking" id="negmarking" />
Expand Down