-
-
Notifications
You must be signed in to change notification settings - Fork 89
Provide the user with an option to resume the test or not. #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for arito ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your First Pull Request! Wish you best on your open-source journey 😊
Can we also mute or pause the background music when paused? @abelparayil |
Yeah that is a good idea but, won't the user reduce the volume if they're not interested in background music? |
@abelparayil Yeah that is an option, but I don't think that user will know that the music won't stop if they pause. And that is not good, we need to pause/mute the music while the test is paused. |
Ok no probs, I'll work on that too. |
Hey @prakhartiwari0 I have got a bit busy right now with class work. Maybe you can add the muting audio function as a new issue for someone else to work on with. |
@abelparayil There are some merge conflicts happening, can you please work on them and resolve them? Also if would be great if you could solve the mute audio issue too in this PR only, as it doesn't make sense to have a separate issue just for that, I think it will not be a big task. |
Yeah sure @prakhartiwari0! I'll work it out during this weekend. |
We have merged a PR @abelparayil, I am sorry but can you please once again solve the merge conflicts that are there now? |
Related to #70
Describe the changes you've made
Type of change
What sort of change have you made:
How Has This Been Tested?
I did a local machine test and I have tested whether the correct time is getting displayed or not with some console logs too.
Checklist:
Screenshots (Images)