Skip to content

add wl-gammarelay-rs for night light#1616

Open
Itz-Abhishek-Tiwari wants to merge 2 commits into
prasanthrangan:mainfrom
Itz-Abhishek-Tiwari:night-light
Open

add wl-gammarelay-rs for night light#1616
Itz-Abhishek-Tiwari wants to merge 2 commits into
prasanthrangan:mainfrom
Itz-Abhishek-Tiwari:night-light

Conversation

@Itz-Abhishek-Tiwari

Copy link
Copy Markdown

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • I have included the night light functionality in Hyde.
  • I like the night light because it is perfect for my eyes to work for multiple hours on my system. However, Hyde does not support it, so I included it using wl-gammarelay-rs.
  • wl-gammarelay-rs needs to be installed to use the night light.## Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

N/A

@sitolam

sitolam commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

+1

@zeerayne

zeerayne commented Jun 30, 2024

Copy link
Copy Markdown
Contributor

Did you check it with hyprctl dispatch dpms off and does it still save night light after dpms is back on? Other wayland utils like gammastep does not and need to be restarted.

@Enigma1309

Copy link
Copy Markdown
Contributor

lgtm but i guess it's unnecessary
since hyprshade support is already there (ex:- screenshot.sh)

@zeerayne

Copy link
Copy Markdown
Contributor

Hypershade affects screenshare unfortunately

@rubiin

rubiin commented Sep 15, 2024

Copy link
Copy Markdown
Contributor

anyone? wl-gammarelay-rs vs hyprshade.
I think hyprsahde is more feature rich comparatively.

@Enigma1309

Copy link
Copy Markdown
Contributor

anyone? wl-gammarelay-rs vs hyprshade. I think hyprsahde is more feature rich comparatively.

+1 for hyprshade since hyprshade is simple and works well.

@zeerayne

zeerayne commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

anyone? wl-gammarelay-rs vs hyprshade.

I don't like hypershade because if you take a screenshot or share your screen the hypershade filter will be visible on screenshot/screenshare, which is not I want in most cases.

Scripts which disable hyprshade while screenshot/screenshare are pain to my eyes.

Hyprshare are more feature rich and flexible, but on my practical basis it is not as good, as specific colortemp solutions.

@rubiin

rubiin commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

@zeerayne does wl-gammarelay-rs work as you intend?
Havent tried it

@zeerayne

zeerayne commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

does wl-gammarelay-rs work as you intend?

Yes, it does. All non-hyprland specific colortemp adjusters (gammastep, wl-gammarelay-rs, wlsunset) work like that, only hyprshade works diffirently. I suppose hyprshare appiles filter on some "another" level.

@zeerayne

Copy link
Copy Markdown
Contributor

BUT if you are using hypridle (or run dpms off / dpms on manually ), all (except hyprshade, it works fine) filters will be discarded and should be reapplied. For me I solved this by restarting colortemp adjuster when turning display on:

listener {
    timeout = 600
    on-timeout = hyprctl dispatch dpms off
    on-resume = hyprctl dispatch dpms on && kill $(pidof gammastep) && gammastep -O 4300
}

@rubiin

rubiin commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

have you uploaded your dots on github?

@zeerayne

Copy link
Copy Markdown
Contributor

Nope. I didn't publish dots anywhere

@kRHYME7

kRHYME7 commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

I suppose hyprshare appiles filter on some "another" level.

Yup hyprshade utilizes Hyprlands built-in shader implementation.

@kRHYME7

kRHYME7 commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

uhm

Waiting for the merge for the built-in feature
https://github.com/hyprwm/hyprsunset
hyprwm/Hyprland#8023

@kRHYME7

kRHYME7 commented Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Screenshot while hyprsunset is running
image

Actual
IMG_20241009_185958.jpg

@zeerayne

Copy link
Copy Markdown
Contributor

@kRHYME7 Can you test it with hyprctl dispatch dpms off? Does it save gamma correction after screen is turned on again?

@kRHYME7

kRHYME7 commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

Sure sure will try it later.

hyprsunset-git in aur is available but I think it won't build
I added comments in the aur package site though

@kRHYME7

kRHYME7 commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

I can confirm that as long as the daemon is running continues whatever is set. For things across reboot, a configuration file is used.

@boulder-roller

Copy link
Copy Markdown
Contributor

obsolete with hyprsunset pr in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants