Skip to content

UPDATED perf: optimize performance of waybar cpuinfo and gpuinfo modules #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2024
Merged

UPDATED perf: optimize performance of waybar cpuinfo and gpuinfo modules #2054

merged 4 commits into from
Dec 12, 2024

Conversation

boulder-roller
Copy link
Contributor

Pull Request

This is a copy of #952 but updated so that it could be auto-merged

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@T-Crypt
Copy link
Collaborator

T-Crypt commented Dec 12, 2024

I need to review the PR from Feb / March before merging

Copy link
Collaborator

@T-Crypt T-Crypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and testing with checkout

@T-Crypt T-Crypt merged commit 5555bc7 into prasanthrangan:main Dec 12, 2024
@mislah
Copy link
Contributor

mislah commented Dec 31, 2024

Thanks for working on updating the code and resolving the merge conflicts. While this pull request is based on our earlier work from #952, and most of the code remains unchanged, I noticed that none of the commits from my original pull request are included here.

As someone who dedicated valuable time to this contribution, I believe it's basic etiquette to preserve the proper authorship . I request the maintainers @T-Crypt and @prasanthrangan to revert this PR and consider opening a new one that retains both my and @kRHYME7's commit history and authorship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants