Fix CVE-2025-15138 upload fullpath extension bypass#1419
Open
billyp2340 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CVE-2025-15138, where the upload
fullpathparameter could be used to bypass upload extension validation and influence the final upload destination/name.Changes
$_FILES['file']['name']usingbasename()instead of trusting the submittedfullpath.fullpathonly as a directory hint for folder uploads, not as the authoritative target filename.realpath()and reject paths outsideFM_ROOT_PATH.Security Impact
This prevents attackers from submitting a crafted
fullpathvalue that causes Tiny File Manager to write an uploaded file with a disallowed extension or outside the intended upload root.Testing
FM_ROOT_PATH..partfiles and renames using the validated target path.