forked from aws/amazon-ecs-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
Init agent shadow test #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prateekchaudhry
wants to merge
45
commits into
initAgentIntegration
Choose a base branch
from
initAgentShadowTest
base: initAgentIntegration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply minimumCPUShare to both task and container CPU shares
* Support Unified Cgroups (cgroups v2) closes aws/containers-roadmap#1535 closes aws#3117 This adds support for task-level resource limits when running on unified cgroups (aka cgroups v2) with the systemd cgroup driver. Cgroups v2 has introduced a cgroups format that is not backward compatible with cgroups v1. In order to support both v1 and v2, we have added a config variable to detect which cgroup version the ecs agent is running with. The containerd/cgroups library is used to determine which mode it is using on agent startup. Cgroups v2 no longer can provide per-cpu usage stats, so this validation was removed since we never used it either. * wip * update cgroups library with nil panic bugfix * Initialize and toggle cgroup controllers
Signed-off-by: Justin Terry <[email protected]>
Sending to an unbuffered channel without a select and without a guarantee that something will receive from that channel, is a recipe for a gourutine leak. Make the channel buffered to avoid it. Also, with a buffered channel, no need to spin up a new goroutine to begin with. Just send right after channel creation.
Credentials were not being rotated properly on ECS-A Windows instances. This patch addresses the issue by using the correct file-paths for credentials on supported platforms. The credential chain hierarchy is also updated on ECS-A windows to ensure that credential chain is not broken for other launch types. Signed-off-by: Siddharth Vinothkumar <[email protected]>
Add log message when receiving error during cached image inspection
Stop container when dependencies are non-resolvable
* Resolve go modules/vendor conflicts and add dockerfree-all make target * add build-time configuration and update scripts/comments
Note -- windows tests failing due to unrelated volume size change.
…lding with codesuite
* separated the merge-build and pr-build buildspecs * aim the codebuild stack at the right buildspec * updated the buildspecs to release and sign arm variants as well * updated the build infrastructure to build for arm as well as amd archs * added a note about adding more artifacts to be signed and copied * fixing a couple of other things found in review * added a bucket stack with a bucket policy * missed a letter in the arm build naming * added a missed file in the build directory structure * updated the descriptions for all of the codebuild projects
Author: Ray Allan <[email protected]>
…ot being found (aws#3210) * updated the build infrastructure to build for arm as well as amd archs * added a note about adding more artifacts to be signed and copied * fixing a couple of other things found in review * updated the descriptions for all of the codebuild projects * added a buildspec to pull logs from cloudwatch logs and put them in s3 * give cloudwatch access to write logs to the release bucket * added a logs puller codebuild project that just gets logs from the preceding steps * refactored the adding a new artifact steps to be less wall-of-text-y * resolved an issue where the buildspec wouldn't be found by actions not pulling the whole source
This reverts commit 6f0f7c5e90e8111329e2baa3bc53c32674f4ce58.
This reverts commit 0a867c7710ce53ea3134be9f85eac19fdc79412b.
…-anywhere-install.sh
…h0 if none can be found (aws#498) check ipv4 routes for default network interface, only fall back to eth0 if none can be found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.