Restore workspace search on older Git - #569
Conversation
- Drop git grep --max-count from shared workspace search - Keep result and stdout caps after parse - Document the image Git 2.39 runtime - Cover spaced search paths in workspace-tool tests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Agent ReviewCaution Review did not finish. Run |
Greptile SummaryThis PR restores workspace search compatibility with Debian bookworm Git by removing the unsupported
Confidence Score: 4/5The implementation appears safe to merge, with a non-blocking test-coverage gap around the compatibility behavior being restored. Removing the unsupported option restores the stated runtime compatibility, and existing byte and returned-result limits remain effective; however, the added test would not catch reintroduction of the incompatible argument. Files Needing Attention: test/localWorkspaceTools.test.ts
|
| Filename | Overview |
|---|---|
| src/prWorkspace/localPrWorkspace.ts | Removes git grep --max-count while preserving output-buffer truncation and post-parse result limiting. |
| test/localWorkspaceTools.test.ts | Adds path-with-spaces coverage, but does not directly enforce the older-Git compatibility behavior. |
| docs/adr/0012-full-context-local-pr-workspace.md | Records Git 2.39 compatibility and clarifies workspace-search budget semantics. |
| docs/configuration.md | Documents the search byte and result limits and the minimum Git runtime. |
| docs/operations.md | Connects the runtime image鈥檚 Debian Git version to workspace-search compatibility. |
Prompt To Fix All With AI
### Issue 1
test/localWorkspaceTools.test.ts:486-504
**Compatibility regression is untested**
This test verifies that paths containing spaces work, but it would still pass if `--max-count` were reintroduced because CI uses a newer Git version. Add coverage that rejects unsupported arguments or run this search test against the documented Git 2.39 runtime so the restored compatibility remains enforced.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "style: format workspace search files" | Re-trigger Greptile
|
PR Agent could not generate a description for this pull request after retries. Try |
|
/review |
- Add a PATH git wrapper that exits 129 on --max-count - Require a successful search match through that wrapper
|
/review |
1 similar comment
|
/review |
Summary
git grep --max-count.Closes #556