Skip to content

Restore workspace search on older Git - #569

Merged
prathamdby merged 3 commits into
mainfrom
pd/fix/workspace-search-git-5c45
Sep 5, 2026
Merged

Restore workspace search on older Git#569
prathamdby merged 3 commits into
mainfrom
pd/fix/workspace-search-git-5c45

Conversation

@prathamdby

Copy link
Copy Markdown
Owner

Summary

  • Shared workspace search no longer passes git grep --max-count.
  • Result and stdout-byte caps still apply after parse.
  • Operator and development docs name Debian bookworm Git 2.39.x as enough.
  • Workspace-tool tests cover a search path that contains a space.

Closes #556

Open in WebOpen in Cursor

- Drop git grep --max-count from shared workspace search
- Keep result and stdout caps after parse
- Document the image Git 2.39 runtime
- Cover spaced search paths in workspace-tool tests
@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pr-agent Ready Ready Preview Sep 5, 2026 10:58am UTC

@zeus-review

zeus-review Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

PR Agent Review

Caution

Review did not finish. Run /review to try again.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR restores workspace search compatibility with Debian bookworm Git by removing the unsupported git grep --max-count argument while retaining post-parse result limiting and bounded subprocess output.

  • Updates operator, configuration, development, cloud, and architectural documentation to identify Git 2.39.x as supported.
  • Adds workspace-search coverage for paths containing spaces.
  • Leaves the compatibility-specific behavior without a regression test against Git 2.39 or an equivalent unsupported-argument guard.

Confidence Score: 4/5

The implementation appears safe to merge, with a non-blocking test-coverage gap around the compatibility behavior being restored.

Removing the unsupported option restores the stated runtime compatibility, and existing byte and returned-result limits remain effective; however, the added test would not catch reintroduction of the incompatible argument.

Files Needing Attention: test/localWorkspaceTools.test.ts

Important Files Changed

Filename Overview
src/prWorkspace/localPrWorkspace.ts Removes git grep --max-count while preserving output-buffer truncation and post-parse result limiting.
test/localWorkspaceTools.test.ts Adds path-with-spaces coverage, but does not directly enforce the older-Git compatibility behavior.
docs/adr/0012-full-context-local-pr-workspace.md Records Git 2.39 compatibility and clarifies workspace-search budget semantics.
docs/configuration.md Documents the search byte and result limits and the minimum Git runtime.
docs/operations.md Connects the runtime image鈥檚 Debian Git version to workspace-search compatibility.
Prompt To Fix All With AI
### Issue 1
test/localWorkspaceTools.test.ts:486-504
**Compatibility regression is untested**

This test verifies that paths containing spaces work, but it would still pass if `--max-count` were reintroduced because CI uses a newer Git version. Add coverage that rejects unsupported arguments or run this search test against the documented Git 2.39 runtime so the restored compatibility remains enforced.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "style: format workspace search files" | Re-trigger Greptile

Comment thread test/localWorkspaceTools.test.ts
@zeus-review

zeus-review Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

PR Agent could not generate a description for this pull request after retries. Try /describe again later.

@prathamdby

Copy link
Copy Markdown
Owner Author

/review

- Add a PATH git wrapper that exits 129 on --max-count
- Require a successful search match through that wrapper
@prathamdby

Copy link
Copy Markdown
Owner Author

/review

1 similar comment
@prathamdby

Copy link
Copy Markdown
Owner Author

/review

@prathamdby
prathamdby merged commit 01c443a into main Sep 5, 2026
8 of 9 checks passed
@prathamdby
prathamdby deleted the pd/fix/workspace-search-git-5c45 branch September 5, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Restore workspace search on the deployment Git version

1 participant