Remove unused GitHub helpers and review leftovers - #576
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Agent ReviewCaution PR merged. |
- Delete unused GitHub, quota, audit, history, and intent helpers - Drop unused submitReview constants and repair prompt suffixes - Collapse askSafety re-exports, Context7 parsing, and the file-list wrap - Trim GITHUB_API_TOOL_NAMES to live publish and submit tools - Point ack progress at ACTIVE_WORK_STATUSES
- Name MAX_THREAD_PUBLISH_CALLS as the live inline-batch cap - Point cached-diff capture at ingestListPullRequestFilesResult
prathamdby
force-pushed
the
pd/refactor/reduce-complexity
branch
from
September 5, 2026 20:00
15550fb to
503bda4
Compare
- Fold triage and verification run harnesses into the executor-facing run functions - Move summary-comment upsert lock and claim into summaryCommentUpsert.ts - Share workspace free-space checks and the CI completed-run schema - Delete parseInstallationId, assertBuiltinPiProvider, llmsTxtResponse, and scripts/bench-performance.mjs
Collapse duplicate wrappers and unused helper files
Owner
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/github/reviewPublish.tsdeleteslistPullRequestReviewCommentsForReviewandgetPullRequestReviewComment. The diff also deletessrc/github/reviewPublishRetry.ts.src/settings/reviewConstants.tsdeletesMAX_REVIEW_PUBLISH_CALLS,REVIEW_MIN_CONFIDENCE,PUBLISH_BUDGET_EXHAUSTED_MESSAGE,REVIEW_DIFF_CACHE_REQUIRED_MESSAGE, andReviewSize.docs/configuration.mdandCONTEXT.mddrop those names.redactOutboundSecretsfromsrc/security/redactOutboundSecrets.tsandMAX_ASK_QUESTION_CHARSfrom settings.sanitizeToolResultForAskkeeps thegetWorkspaceBlamebranch.buildContext7ToolsusestoExecutorfromdefineWorkspaceTool.ts.buildReviewRunSetupno longer callswrapListPullRequestFilesDiffIngestion. That function is gone fromreviewDiffIndex.ts.GITHUB_API_TOOL_NAMESkeeps the essential publish and submit names plussearchCode.canAckPublishProgressusesACTIVE_WORK_STATUSES. The diff deletes unused helpers inaskQuota.ts,agentAudit.ts,findingHistoryRepository.ts,withOperationIntent.ts, andtypes.ts.MAX_THREAD_PUBLISH_CALLSandingestListPullRequestFilesResult.Details
The GitHub publish module loses two unused comment helpers. The retry file goes with them.
src/github/ ├── reviewPublish.ts -├── reviewPublishRetry.ts └── rateLimitCircuit.tsAsk callers stop importing secrets and limits through
askSafety.ts.Context7 executors share the workspace
toExecutorparse path.Review setup no longer wraps a
listPullRequestFilesexecutor.The circuit name set drops unused REST and
submitReviewaliases.Ack progress reads the shared active-status list.
ADR 0009 points the publish budget and cached-diff capture at the live symbols.