Skip to content

Update stop_sign_urban_intersection_3c.json#26

Open
SHITIANYU-hue wants to merge 2 commits into
praveen-palanisamy:masterfrom
SHITIANYU-hue:patch-1
Open

Update stop_sign_urban_intersection_3c.json#26
SHITIANYU-hue wants to merge 2 commits into
praveen-palanisamy:masterfrom
SHITIANYU-hue:patch-1

Conversation

@SHITIANYU-hue
Copy link
Copy Markdown

When I run :

python baseline_agent.py --config /home/tianyushi/code/macadgym/src/macad_gym/envs/intersection/stop_sign_urban_intersection_3c.json

in the path: /home/tianyushi/code/macad-agents/src/macad_agents

I found some configurations are missing in this jason file.

When I run :

python baseline_agent.py --config /home/tianyushi/code/macad-gym/src/macad_gym/envs/intersection/stop_sign_urban_intersection_3c.json 

in the path: /home/tianyushi/code/macad-agents/src/macad_agents

I found some configurations are missing in this jason file.
Copy link
Copy Markdown
Owner

@praveen-palanisamy praveen-palanisamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

"env": {
"server_map": "/Game/Carla/Maps/Town03",
"render": true,
"render_x_res": 800,
Copy link
Copy Markdown
Owner

@praveen-palanisamy praveen-palanisamy Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the extra space in the beginning of this line (Line 6) and the next line (Line 7) so that it aligns with the previous line (Line 5)?
This will maintain readability with uniform visual indent.

"spectator_loc": [140, 68, 9],
"synch_server": true
"sync_server": true,
"fixed_delta_seconds": 0.05
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Needs a visual indent fix. Please remove the extra space in the beginning.

"squash_action_logits": false,
"verbose": false,
"use_depth_camera": false,
"use_depth_camera": false,
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change to remove the extra space in the beginning.

"use_depth_camera": false,
"send_measurements": false,
"enable_planner": true,
"enable_planner": true,
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change to keep the visual indent aligned.

@praveen-palanisamy
Copy link
Copy Markdown
Owner

@SHITIANYU-hue , you can make the changes and update this PR by pushing to the same branch (SHITIANYU-hue:patch-1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants