Issue 479: Support Docusaurus format #594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 12, 2021 11:23
Signed-off-by: Claudio Fahey <[email protected]>
Signed-off-by: Claudio Fahey <[email protected]>
Signed-off-by: Claudio Fahey <[email protected]>
Signed-off-by: Claudio Fahey <[email protected]>
derekm
force-pushed
the
issue-479-docusaurus
branch
from
7a3496e to
e5b9c0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
=========================================
Coverage 82.50% 82.50%
Complexity 427 427
=========================================
Files 40 40
Lines 2132 2132
Branches 187 187
=========================================
Hits 1759 1759
Misses 234 234
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crazyzhou
requested changes
Nov 15, 2021
Signed-off-by: Derek Moore <[email protected]>
derekm
force-pushed
the
issue-479-docusaurus
branch
from
6553c49 to
96098eb
Compare
derekm
commented
Nov 17, 2021
| flinkShadowJar group: 'io.pravega', name: 'pravega-connectors-flink-1.11_2.12', version: '0.9.0' | ||
| ``` | ||
| flinkShadowJar group: 'io.pravega', name: 'pravega-connectors-flink-${versions['flink-minor']}_${versions.scala}', version: '${versions['flink-connectors']}'`} | ||
| </code></pre> |
There was a problem hiding this comment.
What are the correct latest versions here, @crazyzhou? Version info comes from here: pravega/docs@cf71c4b#diff-21a0578522c567f65881e4e8dc3aaace32d60dbdabf2730082b7d9da9f6cb4d0R13
There was a problem hiding this comment.
flink: 1.13.2
flink.minor: 1.13
scala: 2.12
flink-connectors: 0.10.1
|
Any progress on this PR? @derekm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Update docs to support Docusaurus
Purpose of the change
Fixes #479
How to verify it
Build with github.com/pravega/docs