Validation improvement #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Amit-Singh40
changed the base branch from
master
to
stability-improvements-v2
Amit-Singh40
force-pushed
the
validation-improvement
branch
from
1c49317 to
bba2df5
Compare
Signed-off-by: Amit-Singh40 <[email protected]>
Amit-Singh40
requested review from
sachin-j-joshi,
abhinb,
kuldeepk3 and
dada-dell-emc
Signed-off-by: Amit-Singh40 <[email protected]>
sachin-j-joshi
approved these changes
Jan 23, 2024
abhinb
reviewed
Jan 23, 2024
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/DeviceDriver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amit-Singh40 <[email protected]>
abhinb
approved these changes
Jan 23, 2024
Signed-off-by: Amit-Singh40 <[email protected]>
sure |
…validation-improvement
Signed-off-by: Amit-Singh40 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
PSC code lacks general parameter and argument validation. Using Preconditions to validate arguments
Purpose of the change
Validation improvement.
What the code does
Improves validation and parameter checking
How to verify it
NA