Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load logback for windows #50

Conversation

Amit-Singh40
Copy link

Change log description
User can specify the path of the logback file to load it.

Purpose of the change
Ability to load logback.xml for windows

What the code does
Ability specify the path for logback file

How to verify it
You can try to load logback with DEBUG mode enabled and you should see DEBUG output in the log file.

Signed-off-by: Amit-Singh40 <[email protected]>
Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Amit-Singh40 <[email protected]>
@sachin-j-joshi sachin-j-joshi merged commit 4a226dc into pravega:stability-improvements-v2 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants