Issue 20: auto detect whether stream includes SchemaRegistry encoding info#42
Open
adrdc wants to merge 13 commits intopravega:mainfrom
Open
Issue 20: auto detect whether stream includes SchemaRegistry encoding info#42adrdc wants to merge 13 commits intopravega:mainfrom
adrdc wants to merge 13 commits intopravega:mainfrom
Conversation
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
… action arduino/setup-protoc that was used for github action Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
karansinghneu
approved these changes
Sep 7, 2021
chipmaurer
approved these changes
Sep 7, 2021
Contributor
chipmaurer
left a comment
chipmaurer
left a comment
There was a problem hiding this comment.
Had reviewed this prior to your time off.
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
Signed-off-by: Andrew Robertson <andrew.robertson@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Currently we rely on a client application adding a separate boolean property to pravega SchemaRegistry group properties to determine if the objects written to the stream use SchemaRegistry serializers and thus schema data is managed automatically (and encoding info is inlined in the raw event data)
This PR removes the need for this out-of-band property to be set, and will auto-detect.