issue-589-Added imagepullsecrets for both helm hooks in zk-operator charts#590
Draft
krishnadas-menon wants to merge 1 commit intopravega:masterfrom
Draft
Conversation
…harts Signed-off-by: Krishnadas M <krishnadas.menon@ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 12 12
Lines 1633 1633
=======================================
Hits 1403 1403
Misses 145 145
Partials 85 85 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change log description
Currently the helm hooks used in zookeeper operator doesn't provide a mechanism to add imagepullsecrets to pull images from private registry.
The PR could help us to override this limitation.
Purpose of the change
Fixes #589
What the code does
The code snippet will render the imagepull secrets added in either global section OR under hooks.serviceAccount.imagePullSecrets in values file.
How to verify it