Rename ruby files to avoid smashing prawn files#32
Open
keith-packard wants to merge 1 commit into
Open
Conversation
Move all files aside from templates.rb to prawn/templates to avoid smashing any existing files from prawn or pdf packages. Signed-off-by: Keith Packard <keithp@keithp.com>
mathieujobin
approved these changes
Nov 7, 2023
jkraemer
added a commit
to jkraemer/prawn-templates
that referenced
this pull request
Apr 1, 2026
…dowing Based on upstream PR prawnpdf#32. Files at lib/pdf/core/*.rb and lib/prawn/document/internals.rb shadowed identically-named files in the pdf-core gem, causing conflicts in non-Bundler packaging systems (e.g. Debian). Moves all files under lib/prawn/templates/ and updates require paths accordingly. Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all files aside from templates.rb to prawn/templates to
avoid smashing any existing files from prawn or pdf packages.
This PR is relative to 0.1.2 as that's the version I'm packaging for debian.
Signed-off-by: Keith Packard keithp@keithp.com