fix: fall back to amd64 h2spec on Apple Silicon#53
Merged
shaneutt merged 1 commit intopraxis-proxy:mainfrom Apr 18, 2026
Merged
fix: fall back to amd64 h2spec on Apple Silicon#53shaneutt merged 1 commit intopraxis-proxy:mainfrom
shaneutt merged 1 commit intopraxis-proxy:mainfrom
Conversation
shaneutt
previously approved these changes
Apr 18, 2026
h2spec v2.6.0 has no arm64 release. On darwin/arm64, `make tools` tries to download `h2spec_darwin_arm64.tar.gz` which does not exist, causing the conformance test suite to fail. Use the amd64 binary instead, which runs under Rosetta 2.
shaneutt
force-pushed
the
fix/h2spec-darwin-arm64
branch
from
37e50d7 to
b366399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make toolsfails on Apple Silicon (darwin/arm64) because h2spec v2.6.0 has noarm64release — the download URLh2spec_darwin_arm64.tar.gzdoes not existh2spec_strict_conformancetest to fail since the binary is never installedH2SPEC_ARCHvariable that falls back toamd64ondarwin_arm64, since the x86_64 binary runs fine under Rosetta 2Test plan
make toolsconstructs the correct download URL (h2spec_darwin_amd64.tar.gz) on an arm64 Mach2specbinary runs correctly under Rosetta 2h2spec_strict_conformancetest passes