Skip to content

Don't accept YAML with unrecognized fields#59

Merged
shaneutt merged 2 commits intopraxis-proxy:mainfrom
esnible:strict-yaml-parsing
Apr 26, 2026
Merged

Don't accept YAML with unrecognized fields#59
shaneutt merged 2 commits intopraxis-proxy:mainfrom
esnible:strict-yaml-parsing

Conversation

@esnible
Copy link
Copy Markdown
Member

@esnible esnible commented Apr 20, 2026

Resolves #58

Parse with serde(deny_unknown_fields) to prevent invisible typos from producing unexpected results.

@shaneutt shaneutt force-pushed the strict-yaml-parsing branch from 82c819f to e5dad03 Compare April 24, 2026 13:10
@shaneutt shaneutt self-assigned this Apr 24, 2026
@shaneutt shaneutt added the bug Something isn't working label Apr 24, 2026
@shaneutt shaneutt moved this to Review in AI Gateway Apr 24, 2026
@shaneutt shaneutt added this to the v0.5.0 milestone Apr 24, 2026
@praxis-bot praxis-bot marked this pull request as draft April 24, 2026 20:19
@praxis-bot
Copy link
Copy Markdown
Collaborator

Converted to draft: required checks failing.

esnible added 2 commits April 25, 2026 18:24
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible force-pushed the strict-yaml-parsing branch from e5dad03 to 00621a1 Compare April 25, 2026 23:11
@esnible esnible marked this pull request as ready for review April 25, 2026 23:23
@esnible
Copy link
Copy Markdown
Member Author

esnible commented Apr 25, 2026

The failure were caused by my addition of #[serde(deny_unknown_fields)] to StaticResponseConfig. I removed that, and the tests now pass.

@shaneutt shaneutt merged commit 6a6dea0 into praxis-proxy:main Apr 26, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in AI Gateway Apr 26, 2026
@esnible esnible deleted the strict-yaml-parsing branch April 26, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat: Guard against invalid YAML

3 participants