Skip to content

Disable the certificate rotation test on macOS#71

Merged
shaneutt merged 2 commits intopraxis-proxy:mainfrom
esnible:disable-cert-test-macos
Apr 24, 2026
Merged

Disable the certificate rotation test on macOS#71
shaneutt merged 2 commits intopraxis-proxy:mainfrom
esnible:disable-cert-test-macos

Conversation

@esnible
Copy link
Copy Markdown
Member

@esnible esnible commented Apr 23, 2026

Resolves #54

This "resolves" the testing problem on macOS by disabling the certificate rotation test on macOS.

The Mac's fsNotify is weird, especially on temp directories. Multiple attempts (including with Opus 4.6) to get directory watching to work failed.

(Getting a clean test run on the Mac, even if it skips this one test, seems important because every fix I make with Claude notices that one of the tests is broken and Claude gets concerned that an unrelated change broke the cert rotation test.)

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible marked this pull request as ready for review April 23, 2026 11:54
@esnible esnible requested a review from shaneutt April 23, 2026 11:54
@esnible esnible mentioned this pull request Apr 23, 2026
@shaneutt shaneutt self-assigned this Apr 24, 2026
@shaneutt shaneutt added the bug Something isn't working label Apr 24, 2026
@shaneutt shaneutt moved this to Review in AI Gateway Apr 24, 2026
@shaneutt shaneutt added this to the v0.5.0 milestone Apr 24, 2026
@shaneutt shaneutt merged commit 684d382 into praxis-proxy:main Apr 24, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in AI Gateway Apr 24, 2026
@esnible esnible deleted the disable-cert-test-macos branch April 24, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Tests fail on macOS

2 participants