fix: add HIIT activity type support for Strava mapping#221
Open
paulsclaw wants to merge 3 commits into
Open
Conversation
- Add 'HIIT' to sportTypeMapping in StravaActivityMapper.ts - Map Strava sport_type 'HIIT' to activity type 'HIIT' - Add test case for HIIT activity mapping - Add test case for HIIT activity type detection - All existing tests continue to pass
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where HIIT activities uploaded via Strava are being misclassified as "lo cardio" instead of HIIT.
Root Cause
The StravaActivityMapper.ts didn't include HIIT in its sportTypeMapping. When a Strava activity has sport_type "HIIT", it was not matched to any activity type and fell through.
Changes
Testing
Ran
npm test -- strava-mapping.test.ts- all tests pass (11 tests including 2 new HIIT tests)