Round score to two decimal places in Strava notifications#238
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round the
pointsEarnedscore to two decimal places when displaying in Strava activity imported/updated notifications. This ensures consistent formatting of point values in notification messages, removing unnecessary trailing zeros (e.g.,10.00→10,10.50→10.5).Changes
pointsEarnedto 2 decimal places instrava_importnotification messagepointsEarnedto 2 decimal places instrava_updatenotification messagepreviousPointsEarnedto 2 decimal places instrava_updatenotification message (when showing "was X")Implementation Details
Used
parseFloat(points.toFixed(2))to round to 2 decimal places while stripping trailing zeros. Changes made inapps/web/app/challenges/[id]/(dashboard)/notifications/notifications-list.tsx.Testing
Notes
This is a straightforward formatting change to notification messages. No new functionality or logic is introduced, only the display format of numeric values.
https://claude.ai/code/session_01XwvSBeSRKUBieqeXhYi54U