Fix: Strava canonical metric keys + re-scoring migration for 0-point activities#37
Merged
prazgaitis merged 2 commits intomainfrom Feb 15, 2026
Merged
Conversation
…ation 1. Strava extractMetrics now also sets 'miles' and 'kilometers' keys alongside 'distance_miles' and 'distance_km', ensuring scoring works even without alias resolution. 2. Added rescoreStrava migration to fix existing activities that were scored with 0 points before the metric alias fix (082141c). Run with dryRun=true first to preview, then dryRun=false to apply. Fixes #35
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
Problem
Strava activities stored metrics as
distance_miles/distance_kmbut scoring configs usemiles/kilometers. Before commit 082141c, the scoring code did direct key lookup without alias resolution, resulting in 0 points for Strava activities.The alias fix was deployed but existing activities were never re-scored.
Changes
1.
packages/backend/lib/strava.tsNow also sets canonical
milesandkilometerskeys inextractMetrics(), ensuring scoring works regardless of alias resolution.2. Re-scoring migration
packages/backend/mutations/rescoreStrava.ts- Internal mutation that finds all Strava activities with 0 points and recalculates their scorespackages/backend/actions/rescoreStravaActivities.ts- Action wrapperdryRunmode to preview before applyingpointsEarnedanduserChallenges.totalPointsUsage
After deploying, run via Convex dashboard:
Review output, then run with
dryRun: falseto apply.