Skip to content

fix: Ensure newly-added files show up as 'changed' - #127

Closed
rschristian wants to merge 1 commit into
masterfrom
fix/added-files
Closed

fix: Ensure newly-added files show up as 'changed'#127
rschristian wants to merge 1 commit into
masterfrom
fix/added-files

Conversation

@rschristian

@rschristian rschristian commented Dec 14, 2025

Copy link
Copy Markdown
Member

Seeing this issue here where a newly-added file lands in the "unchanged" list when it shouldn't.

The file should only be unchanged if there's a delta of 0 AND the original size is not 0:

} else if (originalSize === 0) {
deltaText += ` (new file)`;

@github-actions

github-actions Bot commented Dec 14, 2025

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 76 kB

ℹ️ View Unchanged
Filename Size
index.js 76 kB

compressed-size-action

@rschristian

Copy link
Copy Markdown
Member Author

After further debugging I've realized this is actually a consequence of not having a proper clean script, though the ergonomics there aren't great at the moment. Will have a separate PR to improve slightly.

@rschristian
rschristian deleted the fix/added-files branch December 14, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant