fix: Ensure newly-added files show up as 'changed'#127
Closed
rschristian wants to merge 1 commit intomasterfrom
Closed
fix: Ensure newly-added files show up as 'changed'#127rschristian wants to merge 1 commit intomasterfrom
rschristian wants to merge 1 commit intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 76 kB ℹ️ View Unchanged
|
4eabead to
7f15722
Compare
Member
Author
|
After further debugging I've realized this is actually a consequence of not having a proper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing this issue here where a newly-added file lands in the "unchanged" list when it shouldn't.
The file should only be unchanged if there's a delta of 0 AND the original size is not 0:
compressed-size-action/src/utils.js
Lines 82 to 83 in 98b0edc