fix: avoid double npm run commands if build-script is given as input - #133
Closed
ali-garajian wants to merge 2 commits into
Closed
fix: avoid double npm run commands if build-script is given as input#133ali-garajian wants to merge 2 commits into
ali-garajian wants to merge 2 commits into
Conversation
rschristian
reviewed
Feb 22, 2026
Comment on lines
-63
to
+65
| console.log(`Building using ${packageManager} run ${buildScript}`); | ||
| await exec(`${packageManager} run ${buildScript}`); | ||
| console.log(`Building using ${buildScript}`); | ||
| await exec(buildScript); |
Member
There was a problem hiding this comment.
The exec calls cannot be touched, this would be a breaking change.
#126 already made this change for v3, but for v2, we're left treating build-script as a script name, e.g., build, build:core, etc. Not a full command.
You can try to handle the console logs on their own if you want to though.
Needs to be updated here too:
compressed-size-action/src/index.js
Lines 120 to 121 in 6cb3a84
Edit: Or apparently not, as we're missing a console.log there. Oops
Author
There was a problem hiding this comment.
oh you're right! I didn't count for build-script being a script name :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this screenshot is from preact repo's ci.
notice
... npm run npm run --if-present noop