Add a warning to make it clear it's not suitable for forked PRs - #141
Closed
eoghanmurray wants to merge 1 commit into
Closed
Add a warning to make it clear it's not suitable for forked PRs#141eoghanmurray wants to merge 1 commit into
eoghanmurray wants to merge 1 commit into
Conversation
This is an alternative to preactjs#140
rschristian
reviewed
Mar 17, 2026
| @@ -1,5 +1,8 @@ | |||
| # compressed-size-action | |||
|
|
|||
| > [!CAUTION] | |||
Member
There was a problem hiding this comment.
This definitely doesn't warrant an all-caps warning at the very top of the ReadMe for a limitation in behavior.
Contributor
Author
There was a problem hiding this comment.
That's special github syntax for generating a callout box, all-caps wouldn't show up in output
Member
There was a problem hiding this comment.
Ah, fair. Still not appropriate IMO
Member
|
Closing, definitely not the messaging we think is needed. Can tweak the existing PR isntead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #140