Skip to content

feat: add base-ref input to override PR base branch#146

Merged
rschristian merged 2 commits into
preactjs:masterfrom
jimhigson:feat/base-ref-input
Apr 30, 2026
Merged

feat: add base-ref input to override PR base branch#146
rschristian merged 2 commits into
preactjs:masterfrom
jimhigson:feat/base-ref-input

Conversation

@jimhigson
Copy link
Copy Markdown
Contributor

Closes #145.

Summary

  • Adds a base-ref action input that overrides the PR base branch when resolving the comparison ref
  • When set, baseSha is nulled so fallback logic doesn't re-use the PR's base.sha
  • Null guards on the fetch and reset fallbacks surface a clear error instead of running git ... null
  • README example shows a release-please conditional: default PR base for feature PRs, production for release PRs

@jimhigson
Copy link
Copy Markdown
Contributor Author

example of this working as planned here: jimhigson/head-over-heels-online#773 (comment)

Copy link
Copy Markdown
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, needed a bit of a break from GitHub tbh.

Just a few minor comments, I'll apply them directly & merge in to not require more of your time. We really appreciate it! Will try to cut a release in the couple of days to make this available.

Comment thread src/index.js Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
@rschristian rschristian merged commit f384866 into preactjs:master Apr 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: support setting base-ref as a parameter

2 participants