test: ignore suggestions in snapshots#39
Merged
marvinhagemeister merged 1 commit intopreactjs:masterfrom Jun 30, 2025
Merged
Conversation
ESLint 8 doesn't seem to return these, so we can just ignore them for now I think. This will allow us to run tests against 8.x and 9.x.
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: |
Member
There was a problem hiding this comment.
Nit: should this be this?
Suggested change
| pull_request: | |
| pull_request: | |
| branches: [main] |
Contributor
Author
There was a problem hiding this comment.
if we only want it to run on PRs to main, you're right i think
i just thought we may as well run on all branches, but maybe thats excessive 🤔
Member
There was a problem hiding this comment.
Fair point. Was mostly curious because I didn't know that you can leave anything after a colon in yaml empty.
marvinhagemeister
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint 8 doesn't seem to return these, so we can just ignore them for
now I think. This will allow us to run tests against 8.x and 9.x.
last one i think?
we can probably release it if CI passes 🤔 or at least a pre-release