Skip to content

chore: Cleanup silly fragment usage #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 1 commit into from
Dec 14, 2025
Merged

chore: Cleanup silly fragment usage #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { h, cloneElement, render, hydrate, Fragment } from 'preact';
import { h, cloneElement, render, hydrate } from 'preact';

/**
* @typedef {import('./internal.d.ts').PreactCustomElement} PreactCustomElement
Expand Down Expand Up @@ -177,8 +177,7 @@ function Slot(props, context) {
}
}
};
const { useFragment, ...rest } = props;
return h(useFragment ? Fragment : 'slot', { ...rest, ref });
return h('slot', { ...props, ref });
}

function toVdom(element, nodeName, options) {
Expand Down Expand Up @@ -210,9 +209,8 @@ function toVdom(element, nodeName, options) {
const shadow = !!(options && options.shadow);

// Only wrap the topmost node with a slot
const wrappedChildren = nodeName
? h(Slot, { useFragment: !shadow }, children)
: children;
const wrappedChildren =
nodeName && shadow ? h(Slot, null, children) : children;

if (!shadow && nodeName) {
element.innerHTML = '';
Expand Down