Feature: accept regular expression matching#227
Open
mingard wants to merge 12 commits intopreactjs:mainfrom
Open
Feature: accept regular expression matching#227mingard wants to merge 12 commits intopreactjs:mainfrom
mingard wants to merge 12 commits intopreactjs:mainfrom
Conversation
Member
|
Might have odd interplay with the match ordering from #136 |
Author
|
@developit I'll run some tests. It could prove benificial to introduce some acceptance tests ontop of the current unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
For more specific route matching, this PR introduces a basic regex match execution.
Example
paginated posts: posts/:page?[^\d+$]
single post: posts/:title?
This is only an interim measure to satisfy a project requirement, so I'm open to suggestions.