rerender on props.url change

[halcaponey]

resolves #330

[developit]

I think we can merge this with shouldComponentUpdate above.

	shouldComponentUpdate(props) {
		if (props.url && props.url!==this.state.url) this.routeTo(props.url);
		return !props.static || props.url!=this.props.url || props.onChange!=this.props.onChange;
	}

[developit]

Passing a new URL to <Router> should not call setUrl(), since doing so will change all other Routers on the page.

[developit]

Sorry for the super long delay in reviewing this @halcaponey! Just a few things I think we can address to get this merged.

[developit]

Update looks good. Only thing I want to check is if this is triggering a double-render when changing the URL prop. Ideally we'd propagate the state without forcing a second render, since the router is already being re-rendered with the new URL as a prop.

[halcaponey]

The problem comes from !props.static being always true and since a change on the url prop triggers a setState which triggers a shouldComponentUpdate which returns true because the static prop is not defined.

What is the static prop used for ? It's only called in shouldComponentUpdate.

• If it's false or undefined, shouldComponentUpdate will always return true.
• if it's true then url prop and onChange prop will determine the result of shouldComponentUpdate