Skip to content

docs: add remark to additional modifiers#362

Open
donkeyDau wants to merge 1 commit intopreactjs:mainfrom
donkeyDau:readme-additional-modifiers
Open

docs: add remark to additional modifiers#362
donkeyDau wants to merge 1 commit intopreactjs:mainfrom
donkeyDau:readme-additional-modifiers

Conversation

@donkeyDau
Copy link
Copy Markdown

Information taken from #62

@amiller-gh
Copy link
Copy Markdown

Looks like the package doesn't support all of the remark modifier, just * ? and +:

flags = (route[i].match(/[+*?]+$/) || EMPTY)[0] || '',

Would love to see full support though! Especially for unnamed path segments (ex: /foo(/bar)). Would help tremendously with matching default routes. @developit, interested in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants