ci: Try adding compressed-size-action for build stats#1328
Merged
rschristian merged 8 commits intomasterfrom Sep 30, 2025
Merged
ci: Try adding compressed-size-action for build stats#1328rschristian merged 8 commits intomasterfrom
rschristian merged 8 commits intomasterfrom
Conversation
|
Size Change: -10.9 kB (-2.37%) Total Size: 449 kB
ℹ️ View Unchanged
|
rschristian
force-pushed
the
ci/size-stats
branch
2 times, most recently
from
ae2cf88 to
b8f742f
Compare
rschristian
commented
Sep 30, 2025
| "rollup": "^2.79.1", | ||
| "sucrase": "^3.35.0", | ||
| "vite": "npm:rolldown-vite@^7.1.4", | ||
| "vite": "^7.1.7", |
Member
Author
There was a problem hiding this comment.
rolldown-vite has some known issues when used alongside manualChunks, which is an issue as we make use of this during prerendering. Those that I know of:
- Sourcemaps are always null for our prerender entry, meaning you get no nice error messages if something does go wrong
- The prerender entry looks like this instead of being merged into the actual bundle entry:
import{b as e}from"./index-BKvQVBdq.js";export{e as prerender};- This is an issue w/ this PR especially as we have two
indexfiles: the real app entry and this silly re-export. As you can see above in the comparison,compressed-sizeis comparing the real app entry with the silly re-export, creating such a huge diff. It won't try to intelligently compare the modules. As one of these isn't even meant to exist at all, we can't really fix this either.
Given that the speed up is negligible anyhow, switching back seems reasonable.
rschristian
commented
Sep 30, 2025
Comment on lines
-23
to
-24
| - run: npm ci | ||
| - run: npm run build |
Member
Author
There was a problem hiding this comment.
Intentionally removed as we were basically just checking that it could build/wouldn't error out on malformed markdown or the like which compressed-size will also do.
rschristian
commented
Sep 30, 2025
Comment on lines
-1
to
-2
| size-files: | ||
| - size-plugin.json |
Member
Author
There was a problem hiding this comment.
AFAIK this is unused? I think it comes from back when we were using preact-cli? Not quite sure tbh.
JoviDeCroock
approved these changes
Sep 30, 2025
rschristian
force-pushed
the
ci/size-stats
branch
from
3527c8d to
1a43531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be useful for easier eyeballing of some PRs