Fix:Remove hidden visibility from current menu item#1340
Fix:Remove hidden visibility from current menu item#1340SisyphusZheng wants to merge 1 commit intopreactjs:masterfrom
Conversation
| &.current { | ||
| visibility: hidden; | ||
| } | ||
|
|
There was a problem hiding this comment.
"Performance", or personal aesthetic preferences? There's a very large difference between the PR description and the actual changes, at least in English. Might just be a translation issue but wanted to ask in case I'm misunderstanding you.
Whilst I do prefer always showing the branding/home link on sites I create, I don't think we should be changing this just for personal preference. However, we have spoken in the past about heading styling issues on certain screen sizes (I think near 1000px wide is a bad one) and those I'd absolutely love fixes for, just don't have time myself.
There was a problem hiding this comment.
"Performance", or personal aesthetic preferences? There's a very large difference between the PR description and the actual changes, at least in English. Might just be a translation issue but wanted to ask in case I'm misunderstanding you.
Whilst I do prefer always showing the branding/home link on sites I create, I don't think we should be changing this just for personal preference. However, we have spoken in the past about heading styling issues on certain screen sizes (I think near 1000px wide is a bad one) and those I'd absolutely love fixes for, just don't have time myself.
Oh,what I mean is that there is a gap in the "head" section when displayed on mobile devices(before-1-picture), which doesn't look very aesthetically pleasing. I just want to fix this issue, and displaying the logo directly is simply because this method is more straightforward.
There was a problem hiding this comment.
The gap is quite intentional though, I don't think we need to collapse it/fill in the space necessarily.
If you did really want this, I'd say it should be limited to mobile only & should not have the "current" style applied to it as that looks not great, IMO.
2 participants
I personally believe that the current performance of the website on mobile devices is not optimal, and it would be better if improvements are made.
before:
after:
