revert: #1329 as it's a symptom of another issue#1341
Merged
rschristian merged 1 commit intomasterfrom Sep 22, 2025
Merged
Conversation
JoviDeCroock
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing CRLF line endings was the wrong move, we should not have them to begin with in the project:
preact-www/.editorconfig
Line 5 in 6bd66fb
#1329 was just one of a handful of symptoms (#1331, #1332, #1333, #1334) stemming from the user's editor not adhering to our
.editorconfig, causing a whole number of features to break apart at the seams. Reverting & requiring use of the config is the better path, IMO.