Merged
Conversation
rschristian
commented
Sep 30, 2025
Comment on lines
+72
to
+85
| The first argument must be a valid Virtual DOM Element, which represents either a component or an element. When passing a Component, it's important to let Preact do the instantiation rather than invoking your component directly, which will break in unexpected ways: | ||
|
|
||
| ```jsx | ||
| const App = () => <div>foo</div>; | ||
|
|
||
| // DON'T: Invoking components directly means they won't be counted as a | ||
| // VNode and hence not be able to use functionality relating to vnodes. | ||
| render(App(), rootElement); // ERROR | ||
| render(App, rootElement); // ERROR | ||
|
|
||
| // DO: Passing components using h() or JSX allows Preact to render correctly: | ||
| render(h(App), rootElement); // success | ||
| render(<App />, rootElement); // success | ||
| ``` |
Member
Author
There was a problem hiding this comment.
Little switch-er-roo on the sections here, I feel that this is something a lot of folks run into and should be higher up than the instructions on replaceNode
| @@ -0,0 +1,102 @@ | |||
| --- | |||
Member
Author
There was a problem hiding this comment.
Mostly copy/pasted from preact-root-fragement's README.md
Comment on lines
+474
to
+481
| }, | ||
| { | ||
| "name": { | ||
| "en": "Libraries", | ||
| "ru": "Библиотеки", | ||
| "zh": "库" | ||
| }, | ||
| "routes": [ |
Member
Author
There was a problem hiding this comment.
This was an oversight, we are missing sidebar entries for these libraries in v11
JoviDeCroock
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was on my todo list and evidently completely slipped my mind when publishing
preact-root-fragment, whoops.