refactor: Try inlining header icon spritesheet#1346
Closed
rschristian wants to merge 1 commit intomasterfrom
Closed
refactor: Try inlining header icon spritesheet#1346rschristian wants to merge 1 commit intomasterfrom
rschristian wants to merge 1 commit intomasterfrom
Conversation
|
Size Change: +4 B (0%) Total Size: 449 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just testing it out, but the gains from losing a network req & having these available at page load (they're in the header, so if not cached, will pop in, and restoring spritesheets from cache seems mighty slow across all browsers) might outweigh the cachability loss.