Skip to content

feat: Show edit page link / no translation found on tutorial pages #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rschristian wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −4
Draft

feat: Show edit page link / no translation found on tutorial pages #986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d212c
feat: Show edit page link on tutorial pages
rschristian Apr 14, 2023
8dca88e
Merge branch 'master' into feat/edit-tutorial
rschristian Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/controllers/page/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export default function Page({ route, prev, next }, ctx) {
// "current" is the currently *displayed* page ID.

const showTitle = current != 'index' && meta.show_title !== false;
const canEdit = showTitle && current != '404' && current !== '/blog';
const canEdit = showTitle && current != '404';
const hasSidebar = meta.toc !== false && isDocPage(url);

return (
Expand Down
4 changes: 3 additions & 1 deletion src/components/controllers/tutorial/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { useStore, storeCtx } from '../../store-adapter';
import { InjectPrerenderData } from '../../../lib/prerender-data';
import { getContent } from '../../../lib/content';
import { Splitter } from '../../splitter';
import EditThisPage from '../../edit-button';

const IS_PRERENDERING = typeof window === 'undefined';

Expand Down Expand Up @@ -284,7 +285,8 @@ function TutorialView({
}
>
<div class={style.tutorialWindow} ref={content}>
<h1 class={style.title}>{title}</h1>
<EditThisPage show={title != 'Error'} isFallback={page.isFallback} />
<h1>{title}</h1>

<ContentRegion
name={page.current}
Expand Down
4 changes: 2 additions & 2 deletions src/components/controllers/tutorial/style.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
}

& > h1 {
margin: 0;
margin: 2.5rem 0 0;
padding: 0.25em 0;
font-size: 2.5rem;
font-weight: 200;
Expand Down Expand Up @@ -214,7 +214,7 @@
.tutorialWindow {
flex-basis: 100%;

& > * {
& > :not(:first-child) {
max-width: 700px;
margin-left: auto;
margin-right: auto;
Expand Down