Skip to content

fix: Always set props in a CE's 'observedAttributes' as attributes #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hesxenon wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Draft

fix: Always set props in a CE's 'observedAttributes' as attributes #4478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a467a3
fix: don't set idl on custom elements that are interested in the corr…
Aug 20, 2024
5ca6c52
fix(tests): tsc checks js code in toolchain - this fix can't be check…
Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/diff/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ export function setProperty(dom, name, value, oldValue, namespace) {
name != 'colSpan' &&
name != 'role' &&
name != 'popover' &&
// observedAttributes can exist as a static property on custom elements
// a runtime check here has no tangible benefit apart from satisfying typescript
// which runs later in the toolchain
// @ts-ignore
!dom.constructor.observedAttributes?.includes(name) &&
name in dom
) {
try {
Expand Down