Skip to content

Experiment whether this leads to better function inlining #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 27, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-1.44ms - +9.96ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.05ms - +0.13ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.77ms - +0.95ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 0% - 3% (0.01ms - 0.45ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.77ms - +1.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +7% (-0.00ms - +0.15ms)
    preact-local vs preact-main
  • todo: slower ❌ 0% - 4% (0.04ms - 1.30ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.26ms - +1.04ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +2% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -9% - +2% (-0.61ms - +0.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +3% (-0.03ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local1025.57ms - 1035.06ms-unsure 🔍
-0% - +1%
-1.44ms - +9.96ms
preact-main1022.89ms - 1029.21msunsure 🔍
-1% - +0%
-9.96ms - +1.44ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.67ms-unsure 🔍
-0% - +1%
-0.05ms - +0.13ms
preact-main16.53ms - 16.57msunsure 🔍
-1% - +0%
-0.13ms - +0.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.59ms-unsure 🔍
-2% - +2%
-0.03ms - +0.02ms
preact-main1.55ms - 1.59msunsure 🔍
-2% - +2%
-0.02ms - +0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.82ms - 70.97ms-unsure 🔍
-1% - +1%
-0.77ms - +0.95ms
preact-main69.66ms - 70.95msunsure 🔍
-1% - +1%
-0.95ms - +0.77ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.44ms - 7.00ms-unsure 🔍
-9% - +2%
-0.61ms - +0.17ms
preact-main6.67ms - 7.21msunsure 🔍
-3% - +9%
-0.17ms - +0.61ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.49ms - 16.81ms-slower ❌
0% - 3%
0.01ms - 0.45ms
preact-main16.26ms - 16.57msfaster ✔
0% - 3%
0.01ms - 0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.78ms - 3.82ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.78ms - 3.81msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4666
  • Commit: 879892c

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.74ms - 62.94ms-unsure 🔍
-1% - +2%
-0.77ms - +1.00ms
preact-main61.58ms - 62.88msunsure 🔍
-2% - +1%
-1.00ms - +0.77ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-1% - +0%
-0.02ms - +0.01ms
preact-main2.99ms - 3.01msunsure 🔍
-0% - +1%
-0.01ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.87ms - 25.48ms-unsure 🔍
-1% - +3%
-0.19ms - +0.70ms
preact-main24.60ms - 25.24msunsure 🔍
-3% - +1%
-0.70ms - +0.19ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.49ms - 32.79ms-unsure 🔍
-1% - +4%
-0.46ms - +1.31ms
preact-main31.11ms - 32.32msunsure 🔍
-4% - +1%
-1.31ms - +0.46ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local27.41ms - 28.49ms-unsure 🔍
-1% - +5%
-0.25ms - +1.30ms
preact-main26.88ms - 27.98msunsure 🔍
-5% - +1%
-1.30ms - +0.25ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local23.33ms - 24.47ms-unsure 🔍
-3% - +4%
-0.61ms - +1.05ms
preact-main23.07ms - 24.28msunsure 🔍
-4% - +3%
-1.05ms - +0.61ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.53ms - 24.75ms-unsure 🔍
-7% - +0%
-1.64ms - +0.11ms
preact-main24.28ms - 25.53msunsure 🔍
-0% - +7%
-0.11ms - +1.64ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local19.75ms - 20.65ms-unsure 🔍
-3% - +3%
-0.67ms - +0.62ms
preact-main19.76ms - 20.69msunsure 🔍
-3% - +3%
-0.62ms - +0.67ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4666
  • Commit: 879892c

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.11ms - 2.23ms-unsure 🔍
-0% - +7%
-0.00ms - +0.15ms
preact-main2.05ms - 2.14msunsure 🔍
-7% - -0%
-0.15ms - +0.00ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.18ms - 1.23ms-unsure 🔍
-3% - +3%
-0.03ms - +0.04ms
preact-main1.18ms - 1.23msunsure 🔍
-3% - +3%
-0.04ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.40ms - 34.52ms-slower ❌
0% - 4%
0.04ms - 1.30ms
preact-main33.01ms - 33.57msfaster ✔
0% - 4%
0.04ms - 1.30ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.25ms-unsure 🔍
-1% - +0%
-0.01ms - +0.01ms
preact-main1.24ms - 1.26msunsure 🔍
-0% - +1%
-0.01ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.41ms - 31.95ms-unsure 🔍
-4% - +3%
-1.26ms - +1.04ms
preact-main30.43ms - 32.15msunsure 🔍
-3% - +4%
-1.04ms - +1.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.96ms - 2.97msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

Copy link

Size Change: +103 B (+0.13%)

Total Size: 78.6 kB

Filename Size Change
dist/preact.js 4.76 kB +16 B (+0.34%)
dist/preact.min.js 4.79 kB +18 B (+0.38%)
dist/preact.min.module.js 4.79 kB +13 B (+0.27%)
dist/preact.min.umd.js 4.82 kB +18 B (+0.38%)
dist/preact.mjs 4.77 kB +12 B (+0.25%)
dist/preact.module.js 4.77 kB +12 B (+0.25%)
dist/preact.umd.js 4.82 kB +14 B (+0.29%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.12 kB
compat/dist/compat.mjs 4.05 kB
compat/dist/compat.module.js 4.05 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.mjs 3.82 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.mjs 952 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.61%. remained the same
when pulling 879892c on attempt-string-extraction
into bb804cd on main.

@JoviDeCroock JoviDeCroock deleted the attempt-string-extraction branch April 27, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants