Skip to content

refactor (v11): Remove deprecated 'ForwardFn' type from compat #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

rschristian
Copy link
Member

ForwardFn is a Preact-only type, created for internal use originally. This however doesn't match the React name (ForwardRefRenderFunction) and also reverses the order of the generics. #4675 added the React-compatible type, deprecating ForwardFn, and I think it's safe to remove for v11. I can see no usage of it in the wild from a code search here and it'll be pretty quick to correct for any users who do rely on it.

Copy link

github-actions bot commented May 28, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: faster ✔ 0% - 1% (1.58ms - 7.92ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +2% (-0.06ms - +0.27ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.05ms - +1.30ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.15ms - +0.16ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.63ms - +0.82ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +1% (-0.12ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.11ms - +0.33ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.88ms - +1.17ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +5% (-0.36ms - +0.39ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +3% (-0.03ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local960.43ms - 964.03ms-faster ✔
0% - 1%
1.58ms - 7.92ms
preact-main964.37ms - 969.59msslower ❌
0% - 1%
1.58ms - 7.92ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.18ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.49ms - 16.82ms-unsure 🔍
-0% - +2%
-0.06ms - +0.27ms
preact-main16.53ms - 16.57msunsure 🔍
-2% - +0%
-0.27ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.53ms - 1.53msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local68.62ms - 70.08ms-unsure 🔍
-2% - +2%
-1.05ms - +1.30ms
preact-main68.30ms - 70.15msunsure 🔍
-2% - +2%
-1.30ms - +1.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local7.33ms - 7.88ms-unsure 🔍
-5% - +5%
-0.36ms - +0.39ms
preact-main7.33ms - 7.84msunsure 🔍
-5% - +5%
-0.39ms - +0.36ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.27ms - 16.49ms-unsure 🔍
-1% - +1%
-0.15ms - +0.16ms
preact-main16.27ms - 16.49msunsure 🔍
-1% - +1%
-0.16ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.77ms - 3.77ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.77ms - 3.77msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4716
  • Commit: 6660529

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.41ms - 62.46ms-unsure 🔍
-1% - +1%
-0.63ms - +0.82ms
preact-main61.34ms - 62.34msunsure 🔍
-1% - +1%
-0.82ms - +0.63ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.98ms - 2.98msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.51ms - 26.14ms-unsure 🔍
-2% - +1%
-0.55ms - +0.33ms
preact-main25.62ms - 26.25msunsure 🔍
-1% - +2%
-0.33ms - +0.55ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.24ms - 32.55ms-unsure 🔍
-6% - -0%
-1.88ms - +0.01ms
preact-main32.15ms - 33.51msunsure 🔍
-0% - +6%
-0.01ms - +1.88ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.73ms - 29.64ms-unsure 🔍
-0% - +5%
-0.07ms - +1.29ms
preact-main28.07ms - 29.07msunsure 🔍
-4% - +0%
-1.29ms - +0.07ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.54ms - 26.35ms-faster ✔
0% - 5%
0.00ms - 1.25ms
preact-main26.10ms - 27.04msunsure 🔍
-0% - +5%
+0.00ms - +1.25ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.50ms - 23.75ms-unsure 🔍
-2% - +6%
-0.42ms - +1.27ms
preact-main22.13ms - 23.27msunsure 🔍
-5% - +2%
-1.27ms - +0.42ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.74ms - 21.55ms-unsure 🔍
-3% - +3%
-0.60ms - +0.59ms
preact-main20.72ms - 21.58msunsure 🔍
-3% - +3%
-0.59ms - +0.60ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #4716
  • Commit: 6660529

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.05ms - 2.14ms-unsure 🔍
-5% - +1%
-0.12ms - +0.02ms
preact-main2.09ms - 2.20msunsure 🔍
-1% - +6%
-0.02ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.17ms - 1.21ms-unsure 🔍
-2% - +3%
-0.03ms - +0.03ms
preact-main1.16ms - 1.21msunsure 🔍
-3% - +2%
-0.03ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.93ms - 33.23ms-unsure 🔍
-0% - +1%
-0.11ms - +0.33ms
preact-main32.81ms - 33.13msunsure 🔍
-1% - +0%
-0.33ms - +0.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.24ms-unsure 🔍
-1% - +0%
-0.01ms - +0.00ms
preact-main1.23ms - 1.25msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.95ms - 30.50ms-unsure 🔍
-3% - +4%
-0.88ms - +1.17ms
preact-main28.90ms - 30.26msunsure 🔍
-4% - +3%
-1.17ms - +0.88ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.95ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main2.93ms - 2.94msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented May 28, 2025

Size Change: 0 B

Total Size: 46.5 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.73 kB
compat/dist/compat.mjs 3.65 kB
compat/dist/compat.umd.js 3.79 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.umd.js 3.94 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.62 kB
dist/preact.mjs 4.63 kB
dist/preact.umd.js 4.69 kB
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 861 B
jsx-runtime/dist/jsxRuntime.mjs 830 B
jsx-runtime/dist/jsxRuntime.umd.js 934 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@rschristian rschristian merged commit 85a2c8a into v11-2 May 28, 2025
12 checks passed
@rschristian rschristian deleted the types/remove-deprecated-forwardref branch May 28, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants