Account for fragment clones#571
Merged
JoviDeCroock merged 1 commit intomainfrom Jun 28, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 6acc61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preactjs/preact#4680 we fixed a memory leak where Preact would not be able to release top-level Fragments. This fix lead to us cloning the top-level Fragment and its children. Which lead us to this new place where we are suffering from having stale vnodes in memory. This banks on the
_originalproperty which is our VNode ID in Preact to give us the non-stale reference.Resolves #569